chore: fix JavaScript lint errors (issue #8262) #8270
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace './boop.js' with './example.js' in JSDoc examples - Replace new Array() with array literal and push in bessely0-by test
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
stdlib-bot
added
First-time Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
…t/docs/types/index.d.ts
kgryte
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
LGTM after clean-up. Two comments:
- The use of sparse arrays in the test file was intentional. Your original proposed change simply densified the arrays which is not what was wanted.
- You simply swapped one non-existent filename for another. This is also not desired. I just removed the proposed filename changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
ENOENT: no such file or directory, open './boop.js'errorstdlib/no-new-arrayviolations in test fileRelated Issues
This pull request:
Changes
Replaced
'./boop.js'with'./example.js'in JSDoc example comments in the following files:lib/node_modules/@stdlib/utils/async/for-each-right/lib/factory.jslib/node_modules/@stdlib/utils/async/for-each-right/lib/index.jslib/node_modules/@stdlib/utils/async/for-each-right/lib/main.jslib/node_modules/@stdlib/utils/async/for-each-right/docs/types/index.d.tsReplaced
new Array()constructor with array literal and push pattern in:lib/node_modules/@stdlib/math/strided/special/bessely0-by/test/test.main.jsQuestions
No.
Other
All modified files have been tested with ESLint and pass linting validation.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used Claude AI to understand the linting errors, identify the specific issues, and determine the appropriate fix patterns following stdlib conventions. The actual code changes were made manually by me with guidance from Claude on stdlib's coding standards and proper fix implementations.
@stdlib-js/reviewers